Skip to content

Update rules_rust to v0.67.0 (with Rust v1.90.0). #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update rules_rust to v0.67.0 (with Rust v1.90.0). #334

wants to merge 1 commit into from
+55 −7

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 26, 2025 •
edited
Loading

Description

update rules_rust to 0.67.0

@mmorel-35 mmorel-35 mentioned this pull request Nov 26, 2025
Draft
PiotrSikora
PiotrSikora requested changes Nov 26, 2025
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If that's not too much to ask, could you split this into 2 PRs (bump MSRV to Rust 1.68 to fix the CI - changes in .github/workflows/rust.yml and Cargo.toml), and then update rules_rust to 0.67 (which ships with Rust 1.90 or something - we should verify the exact version for the commit message).

@mmorel-35 mmorel-35 changed the title update rules_rust to 0.67.0 and rust 1.68.0 update rules_rust to 0.67.0 Nov 26, 2025
PiotrSikora
PiotrSikora reviewed Nov 26, 2025
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also bump the Rust version to latest supported version? It looks like rules_rust stopped updating the default version in recent releases.

You need to replace rust_repositories() with rust_repositories(versions = ["1.90.0"]) in bazel/dependencies.bzl.

@mmorel-35 mmorel-35 force-pushed the rules_rust branch 2 times, most recently from 26c8293 to 859fdfa Compare November 27, 2025 06:30
@PiotrSikora PiotrSikora changed the title update rules_rust to 0.67.0 update rules_rust to v0.67.0 (with Rust v1.90.0). Nov 28, 2025
@PiotrSikora PiotrSikora changed the title update rules_rust to v0.67.0 (with Rust v1.90.0). Update rules_rust to v0.67.0 (with Rust v1.90.0). Nov 28, 2025
@mmorel-35 mmorel-35 force-pushed the rules_rust branch 2 times, most recently from 01fcced to a2c018b Compare November 28, 2025 08:25
@PiotrSikora
Copy link
Member

PiotrSikora commented Nov 29, 2025

Could you resolve merge conflict here (dependencies -> dependencies_crates)? Thanks!

@mmorel-35
Update rules_rust to v0.67.0 (with Rust v1.90.0).
707a7a3 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 29, 2025

That's ready for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora PiotrSikora is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmorel-35 @PiotrSikora